Ok.

So I know that when the warrior is in water terain, he can use charge. Now, let's say he begins his charge in water, but crosses into non-water terrain.

Does he lose the charge and stop immediately or does he continue the charge?

As long as he starts in water you can use charge. The action is already given even if you went into clear terrain he is still using charge.